Linked by Thom Holwerda on Fri 15th Feb 2013 10:40 UTC
General Development "Since I left my job at Amazon I have spent a lot of time reading great source code. Having exhausted the insanely good idSoftware pool, the next thing to read was one of the greatest game of all time: Duke Nukem 3D and the engine powering it named 'Build'. It turned out to be a difficult experience: The engine delivered great value and ranked high in terms of speed, stability and memory consumption but my enthousiasm met a source code controversial in terms of organization, best practices and comments/documentation. This reading session taught me a lot about code legacy and what helps a software live long." Hail to the king, baby.
Thread beginning with comment 552623
To view parent comment, click here.
To read all comments associated with this story, please click here.
RE[3]: Code Review
by Bill Shooter of Bul on Fri 15th Feb 2013 14:55 UTC in reply to "RE[2]: Code Review"
Bill Shooter of Bul
Member since:
2006-07-14

Really? Well,I guess I've never read outsourced code that did what was required...

When companies I've worked for have out sourced work, we just expect to spend a certain amount of time cleaning it up/ rewriting sections.

Reply Parent Score: 3

RE[4]: Code Review
by henderson101 on Fri 15th Feb 2013 17:20 in reply to "RE[3]: Code Review"
henderson101 Member since:
2006-05-30

Moreover, code that works by black magic or absolute blind luck is no use to anyone. Especially when the quality is so poor, the original offshore developers are incapable of maintaining it and adding new features without creating giant bugs.

Reply Parent Score: 2

RE[5]: Code Review
by Bill Shooter of Bul on Fri 15th Feb 2013 18:33 in reply to "RE[4]: Code Review"
Bill Shooter of Bul Member since:
2006-07-14

Oh yeah, I've seen that before. The code filled with hacks to just meet 80% of the requirements. Send it back to get the other 20% and it comes back missing some of the original requirements it did meet in the first iteration, so it now meets 60%.

Reply Parent Score: 2

RE[4]: Code Review
by moondevil on Fri 15th Feb 2013 19:43 in reply to "RE[3]: Code Review"
moondevil Member since:
2005-07-08

Really? Well,I guess I've never read outsourced code that did what was required...

When companies I've worked for have out sourced work, we just expect to spend a certain amount of time cleaning it up/ rewriting sections.


You are right, one of my specialities in consulting is clean up off-shore code. Yes there are such type of projects.

But there is only so much you can do when you have teams of > 30 developers producing new code every day.

So we only focus on the critical components and test the remaining ones as a black box.

Welcome to the Fortune 500 consulting world...

Reply Parent Score: 3