Linked by Thom Holwerda on Fri 15th Feb 2013 10:40 UTC
General Development "Since I left my job at Amazon I have spent a lot of time reading great source code. Having exhausted the insanely good idSoftware pool, the next thing to read was one of the greatest game of all time: Duke Nukem 3D and the engine powering it named 'Build'. It turned out to be a difficult experience: The engine delivered great value and ranked high in terms of speed, stability and memory consumption but my enthousiasm met a source code controversial in terms of organization, best practices and comments/documentation. This reading session taught me a lot about code legacy and what helps a software live long." Hail to the king, baby.
Thread beginning with comment 552624
To view parent comment, click here.
To read all comments associated with this story, please click here.
RE[3]: Code Review
by Alfman on Fri 15th Feb 2013 14:56 UTC in reply to "RE[2]: Code Review"
Alfman
Member since:
2011-01-28

moondevil,

"After a few sessions of off-shore code review, one really stops caring about code quality as long as what was requested works."

With all due respect, -10 ;)
I've dealt with too much bad code to write it off as ok as long as it works...

Obligatory link to the obfuscated c contests:
http://ioccc.org/years.html

Incidentally, I wish these contests would focus more on algorithmic obfuscation rather than source code obfuscation. I am not impressed with code that's unreadable because of shortened variable names and whitespace elimination. The best obfuscated code is code which is still incomprehensible even though it uses proper whitespace conventions and comments ;)

Reply Parent Score: 5

RE[4]: Code Review
by moondevil on Fri 15th Feb 2013 19:39 in reply to "RE[3]: Code Review"
moondevil Member since:
2005-07-08

In my defence there is not much you can do about it, when you have an offshore team of 60 - 100 developers producing new code every day, while you have 5 guys doing development on the customer site.

There is no way to keep up with it.

Reply Parent Score: 3

RE[4]: Code Review
by christian on Fri 15th Feb 2013 21:11 in reply to "RE[3]: Code Review"
christian Member since:
2005-07-06


...snip...

Obligatory link to the obfuscated c contests:
http://ioccc.org/years.html

Incidentally, I wish these contests would focus more on algorithmic obfuscation rather than source code obfuscation. I am not impressed with code that's unreadable because of shortened variable names and whitespace elimination. The best obfuscated code is code which is still incomprehensible even though it uses proper whitespace conventions and comments ;)


IOCCC is in fact one of those contests. You won't win anything in IOCCC if your code is obvious after running it through indent.

BTW, I think my favourite from this contest is:

http://www.ioccc.org/years.html#1998_banks

Reply Parent Score: 2

RE[5]: Code Review
by Alfman on Fri 15th Feb 2013 21:37 in reply to "RE[4]: Code Review"
Alfman Member since:
2011-01-28

christian,

I took a look, I wanted to see if I could recognize the pittsburgh file. It segfaults for me every time and I'm not about to debug it. But I searched for and found this screenshot:

http://blog.aerojockey.com/post/iocccsim

I can definitely recognize the point!

Reply Parent Score: 2