Linked by Thom Holwerda on Fri 15th Feb 2013 10:40 UTC
General Development "Since I left my job at Amazon I have spent a lot of time reading great source code. Having exhausted the insanely good idSoftware pool, the next thing to read was one of the greatest game of all time: Duke Nukem 3D and the engine powering it named 'Build'. It turned out to be a difficult experience: The engine delivered great value and ranked high in terms of speed, stability and memory consumption but my enthousiasm met a source code controversial in terms of organization, best practices and comments/documentation. This reading session taught me a lot about code legacy and what helps a software live long." Hail to the king, baby.
Thread beginning with comment 552689
To view parent comment, click here.
To read all comments associated with this story, please click here.
RE[5]: Code Review
by Alfman on Fri 15th Feb 2013 21:37 UTC in reply to "RE[4]: Code Review"
Alfman
Member since:
2011-01-28

christian,

I took a look, I wanted to see if I could recognize the pittsburgh file. It segfaults for me every time and I'm not about to debug it. But I searched for and found this screenshot:

http://blog.aerojockey.com/post/iocccsim

I can definitely recognize the point!

Reply Parent Score: 2

RE[6]: Code Review
by christian on Wed 20th Feb 2013 11:34 in reply to "RE[5]: Code Review"
christian Member since:
2005-07-06

christian,

I took a look, I wanted to see if I could recognize the pittsburgh file. It segfaults for me every time and I'm not about to debug it. But I searched for and found this screenshot:

http://blog.aerojockey.com/post/iocccsim

I can definitely recognize the point!


I can segfault it if I feed all the .sc files in, as I understand it has a fixed size internal array for the vertices. Using just horizon.sc and pittsburgh.sc, it works fine with Ubuntu 12.04 (32-bit mode). Perhaps there is some less than 64-bit clean code?

Reply Parent Score: 1