Linked by jessesmith on Wed 5th Nov 2014 10:39 UTC
Linux Over the past year I've been reading a lot of opinions on the new init technology, systemd. Some people think systemd is wonderful, the bee's knees. Others claim that systemd is broken by design. Some see systemd as a unifying force, a way to unite the majority of the Linux distributions. Others see systemd as a growing blob that is slowly becoming an overly large portion of the operating system. One thing that has surprised me a little is just how much people care about systemd, whether their opinion of the technology is good or bad. People in favour faithfully (and sometimes falsely) make wonderful claims about what systemd is and what it can supposedly do. Opponents claim systemd will divide the Linux community and drive many technical users to other operating systems. There is a lot of hype and surprisingly few people presenting facts.
Thread beginning with comment 599099
To view parent comment, click here.
To read all comments associated with this story, please click here.
RE[2]: Complexity
by tbullock on Thu 6th Nov 2014 08:14 UTC in reply to "RE: Complexity"
tbullock
Member since:
2012-01-30

Take a look, its pretty cool!


I have looked; the code idioms are preposterous. I would fire any of my employees who wrote software like that.

Reply Parent Score: 1

RE[3]: Complexity
by Bill Shooter of Bul on Thu 6th Nov 2014 14:34 in reply to "RE[2]: Complexity"
Bill Shooter of Bul Member since:
2006-07-14

Well, judging by your "some things jumped out to me" section in your first post, I don't think you've looked at it enough to understood very much about systemd.

Reply Parent Score: 2

RE[4]: Complexity
by tbullock on Thu 6th Nov 2014 16:59 in reply to "RE[3]: Complexity"
tbullock Member since:
2012-01-30

Well, judging by your "some things jumped out to me" section in your first post, I don't think you've looked at it enough to understood very much about systemd.


Unchecked string slinging for starters; check how many times snprintf is used and how many times its return result is checked.

I see 138 instances. Can any of those overflow? maybe, but we cannot tell nobody is looking.

And what is with all the calls to fput{s,c}....

And missing memory checks on the error paths, I've seen at least 3 of these in 5 minutes.

And missing memory check on memory allocation from a string length

Probable memory leak (allocating memory and no call to free)

Reply Parent Score: 1