Linked by Thom Holwerda on Fri 15th Feb 2013 10:40 UTC
General Development "Since I left my job at Amazon I have spent a lot of time reading great source code. Having exhausted the insanely good idSoftware pool, the next thing to read was one of the greatest game of all time: Duke Nukem 3D and the engine powering it named 'Build'. It turned out to be a difficult experience: The engine delivered great value and ranked high in terms of speed, stability and memory consumption but my enthousiasm met a source code controversial in terms of organization, best practices and comments/documentation. This reading session taught me a lot about code legacy and what helps a software live long." Hail to the king, baby.
Thread beginning with comment 552879
To view parent comment, click here.
To read all comments associated with this story, please click here.
RE[3]: Comment by ilovebeer
by Nelson on Tue 19th Feb 2013 04:14 UTC in reply to "RE[2]: Comment by ilovebeer"
Nelson
Member since:
2005-11-29

Yeah, some of the worst, creakiest, ugliest legacy code I've had the unfortunate job of maintaining is code written by people who think exactly like you.

Code should adhere to good design, period. This isn't about legacy code, or compatibility. The code would be written in the present, and as such, good design could be encouraged from the start.

The goal is to reduce substantially the amount of said ugly code, all while increasing the reliability and maintainability of the code base as a whole.

As a company often we don't control how old code is designed, we do control new code.

Reply Parent Score: 2

RE[4]: Comment by ilovebeer
by ilovebeer on Tue 19th Feb 2013 16:30 in reply to "RE[3]: Comment by ilovebeer"
ilovebeer Member since:
2011-08-08

Yeah, some of the worst, creakiest, ugliest legacy code I've had the unfortunate job of maintaining is code written by people who think exactly like you.

Some of the worst, creakiest, ugliest legacy code you've had to maintain was written by people who think like me.. So, people who think there's a lot of grey area when it comes to what's good and what's bad code. And that often times a codes "goodness" or "badness" is simply subjective opinion. I hope you don't consider yourself a good coder if you disagree with what I just said.

Code should adhere to good design, period.

"Good design" is too much a matter of opinion. Maybe you should choose different wording to better express your viewpoint. For example, providing specifics such as Alfman has.

The goal is to reduce substantially the amount of said ugly code, all while increasing the reliability and maintainability of the code base as a whole.

You disliking how something was done doesn't automatically make it unreliable or hard to maintain. Unreliability is the result of bad programming. Code being difficult to maintain can be the result of a bad programmer doing the job, where the code itself isn't the actual problem but rather your lack of ability is.

Reply Parent Score: 2

RE[5]: Comment by ilovebeer
by Alfman on Tue 19th Feb 2013 17:15 in reply to "RE[4]: Comment by ilovebeer"
Alfman Member since:
2011-01-28

ilovebeer,

"Code being difficult to maintain can be the result of a bad programmer doing the job, where the code itself isn't the actual problem but rather your lack of ability is."

You are throwing around these underhanded insults implying that we're bad coders if a piece of code gives us trouble, but the truth is that even good coders have trouble with bad code. What's the deal with wanting to defend bad code?

Reply Parent Score: 2